[wp-trac] [WordPress Trac] #37527: Customizer: Links within text should be underlined

WordPress Trac noreply at wordpress.org
Tue Aug 30 16:05:33 UTC 2016


#37527: Customizer: Links within text should be underlined
---------------------------------------+--------------------------------
 Reporter:  afercia                    |       Owner:
     Type:  defect (bug)               |      Status:  reviewing
 Priority:  normal                     |   Milestone:  4.7
Component:  Customize                  |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:  ui, accessibility
---------------------------------------+--------------------------------
Changes (by afercia):

 * milestone:  Future Release => 4.7


Comment:

 Refreshed patch with a minimal, and reversed approach. Still thinking the
 best option would be keeping the `<a>` elements underlined by default, and
 then override the style case by case. That's because many of these links
 that are not real links should be changed in buttons sooner or later.
 Haven't touched the widget action links.

 > Note that there is a link within the menu item control that should be
 styled like a link
 Should be OK now, see the "original" link below:
 [[Image(https://cldup.com/kQ-evX_GDz.png)]]

 Worth noting there are still some small inconsistencies here and there.
 For example, the "Delete Menu" `button-link` is underlined while the
 "Remove" menu item `button-link` is not underlined. Not sure why, would be
 nice to review them.
 @celloexpressions do you feel this is a viable approach?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37527#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list