[wp-trac] [WordPress Trac] #36430: Style links on Installing plugin page

[WordPress Trac]

#36430: Style links on Installing plugin page
-----------------------------------+--------------------------------
 Reporter:  ericlewis              |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  4.7
Component:  Plugins                |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  ui-feedback has-patch  |     Focuses:  ui, accessibility
-----------------------------------+--------------------------------

Comment (by afercia):

 Quickly checking history, I think the `button-cancel` class was originally
 introduced for the "Cancel" links in the publish box, see [26247] and
 should not be used to add a left margin, that would affect also the links
 in the publish box increasing the spacing a bit too much, see screenshot
 below:

 [[Image(https://cldup.com/_qBYximv9T.png)]]

 Not sure why it is used in the Comment Moderation screen, probably should
 be removed. Personally, since a primary button is supposed to be unique in
 a page (because there should be just one primary action), I'd go with
 something like:

 {{{
 .update-php .button.button-primary {
         margin-right: 1em;
 }
 }}}

 and I'd remove the `button-cancel` class added on the links, which also
 makes the patch simpler and cleaner.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36430#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform