[wp-trac] [WordPress Trac] #36678: Shift-click in Customizer when collapsed does nothing
WordPress Trac
noreply at wordpress.org
Tue Aug 30 04:13:36 UTC 2016
#36678: Shift-click in Customizer when collapsed does nothing
--------------------------+------------------
Reporter: sixhours | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.7
Component: Customize | Version: 3.9
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
--------------------------+------------------
Changes (by celloexpressions):
* keywords: has-patch dev-feedback => has-patch
Comment:
Thanks for the patch @curdin, nice work!
This looks good to me. The only part I'm unsure about is the naming of the
state. Instead of `collapsed`, maybe `controlsVisible` or possibly
`paneVisible`? I'd like this to be named in a way that could remain
logical if this UI changes drastically in the future. `collapsed` could
also work though, it's just a bit ambiguous about what's collapsed.
Also, it looks like this doesn't work for widgets or menus; I think we'll
need to trigger collapsed to false elsewhere for them, likely somewhere in
`customize-nav-menus.js` and `customize-widgets.js`, as the have their own
implementations of this functionality I believe.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/36678#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list