[wp-trac] [WordPress Trac] #37864: No shiny update when updating a plugin in a non-English site

[WordPress Trac]

#37864: No shiny update when updating a plugin in a non-English site
-----------------------------+-----------------------------------------
 Reporter:  leemon           |       Owner:  ocean90
     Type:  defect (bug)     |      Status:  assigned
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:  4.6
 Severity:  major            |  Resolution:
 Keywords:                   |     Focuses:  javascript, administration
-----------------------------+-----------------------------------------
Changes (by johnbillion):

 * keywords:  needs-testing =>
 * owner:   => ocean90
 * status:  new => assigned


Comment:

 This appears to be an issue with the Spanish translation. It's missing the
 `%5$s` placeholder which adds the `update-link` class attribute which the
 shiny updater uses.

 There's
 [https://translate.wordpress.org/projects/wp/dev/es/default?filters%5Bterm%5D=There+is+a+new+version&filters%5Bstatus%5D=either
 no translation listed on translate.wordpress.org] for the phrase `There is
 a new version of %1$s available. <a href="%2$s" %3$s>View version %4$s
 details</a> or <a href="%5$s" %6$s>update now</a>.` for Spanish (`es_ES`),
 yet a translation does appear in the downloaded translation file: `Hay
 disponible una nueva versión de %1$s. <a href=\"%2$s\" class=\"thickbox\"
 title=\"%3$s\">Ver los detalles de la versión %4$s</a> o <a
 href=\"%5$s\">actualízala ahora</a>.`.

 @ocean90 Can you take a look? This is the third issue we've seen where a
 translation doesn't have the correct placeholder and it's being allowed
 through somehow.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37864#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform