[wp-trac] [WordPress Trac] #37699: Death to Globals Episode #1: A Registry, A Pattern

WordPress Trac noreply at wordpress.org
Sat Aug 27 06:06:52 UTC 2016


#37699: Death to Globals Episode #1: A Registry, A Pattern
----------------------------+------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  4.7
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:
----------------------------+------------------

Comment (by wonderboymusic):

 In [changeset:"38397"]:
 {{{
 #!CommitTicketReference repository="" revision="38397"
 Press This: the file for the `WP_Press_This` class should not produce side
 effects. Similar to what we did in r38355 for `WP_Site_Icon`, drop the
 instances of `global` instantiation for `$wp_press_this` via loading the
 file. The variable can be set inline when necessary. In most of those
 places, if the global is already set, the file does not load and stomp it
 currently.

 See #37699.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37699#comment:38>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list