[wp-trac] [WordPress Trac] #34923: Allow users to more seamlessly create page-based nav menus during customization

[WordPress Trac]

#34923: Allow users to more seamlessly create page-based nav menus during
customization
-------------------------------------+-------------------------------------
 Reporter:  westonruter              |       Owner:  westonruter
     Type:  enhancement              |      Status:  accepted
 Priority:  high                     |   Milestone:  4.7
Component:  Customize                |     Version:  4.3
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch ux-feedback    |     Focuses:  ui, accessibility,
  needs-testing has-screenshots      |  javascript
  needs-unit-tests                   |
-------------------------------------+-------------------------------------

Comment (by mrahmadawais):

 Replying to [comment:74 celloexpressions]:
 > @mrahmadawais it looks like there's still a pixel or two difference in
 the height of the button and the input, although that's better.

 Thanks for the feedback. Care to share a screenshot? Where the issue still
 exists? If you are referring to my screenshots, then it's the button UI
 which makes it look like that, any more padding would make things worse, I
 did try. Changing the UI of the button is not ideal since it is consistent
 everywhere. Will look into it.


 Replying to [comment:75 westonruter]:
 > @mrahmadawais going forward, please push your changes as commits to the
 existing pull request: https://github.com/xwp/wordpress-develop/pull/152
 Coordinating via a PR makes it much easier to see the changes you're
 introducing and it allows us to all collaborate much more easily, and unit
 tests will be run automatically on the PR. You have write access

 I agree my bad.

 > I believe I successfully applied your changes to the pull request:
 https://github.com/xwp/wordpress-develop/compare/67b2452...e17fd31
 > I don't think the changes you're making to `kses.php` are warranted
 here, and should instead be part of a separate ticket. They're not
 required for this ticket, are they?

 My bad, `kses.php` edits were related to another ticket. Minor issue with
 my workflow had the clean start commented in the bash script I wrote to
 get started. Will be careful next time.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34923#comment:77>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform