[wp-trac] [WordPress Trac] #37646: Make wp-settings.php a series of do_actions()

WordPress Trac noreply at wordpress.org
Fri Aug 26 03:45:48 UTC 2016


#37646: Make wp-settings.php a series of do_actions()
--------------------------------------+------------------------------
 Reporter:  johnjamesjacoby           |       Owner:
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Bootstrap/Load            |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  2nd-opinion dev-feedback  |     Focuses:
--------------------------------------+------------------------------

Comment (by DrewAPicture):

 Replying to [comment:5 jorbin]:
 > My biggest worry with tying all includes to actions is that it would
 make all of WordPress pluggable and that feels like a great way to
 increase breakage on updates.  Image a plugin that decides to include it’s
 own version of `src/wp-includes/category-template.php`. Core could never
 add a new function to that file again since it can’t count on that file
 existing. The Autoloader being worked on in #36335 will make it so that we
 don't need to worry about this.  This seems like a dependency before I
 would want to include more actions in the bootstrap process.
 >
 > We need to consider a lot of "what if" situations with this change,
 let's try to brainstorm those out here while we continue to explore this
 issue.

 I'm not so sure we really do need to consider the what-ifs so much. If we
 make it clear that messing with how core loads is effectively "voiding the
 warranty" I'm not sure core support should necessarily extend beyond how
 it's ''intended'' to work.

 There's an immense upside in enabling proverbial forks of WordPress to do
 what they wish with how WordPress is loaded, and very little downside in
 enabling that kind of flexibility, in my opinion – again, with the caveat
 that hooks as-is and as-hooked is how core ''expects'' it to work. Any
 deviation is uncharted territory.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37646#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list