[wp-trac] [WordPress Trac] #31779: Warn users before using a built-in file editor for the first time

[WordPress Trac]

#31779: Warn users before using a built-in file editor for the first time
----------------------------------------+---------------------------------
 Reporter:  helen                       |       Owner:  helen
     Type:  enhancement                 |      Status:  reviewing
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  Themes                      |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  good-first-bug needs-patch  |     Focuses:  ui, administration
----------------------------------------+---------------------------------

Comment (by brocheafoin):

 Replying to [comment:25 boogah]:
 > It'd be nice to have the ability to not hide the interstitial after it
 has been dismissed though. Via a filter, perhaps?

 I don't see the use case for this. If you're that worried about your users
 that you want them to see the warning all the time, you should probably
 just DISALLOW_FILE_EDIT.

 Design-wise, I think the interstitial should be as in-your-face as Chrome
 or Firefox' [http://phishing.safebrowsingtest.com/ malware/phishing
 warning]. It really _is_ the most dangerous part of the WordPress admin.
 One false move could turn your whole site, including the admin, into a
 white screen of death. So here's my wording suggestion for the theme
 editor:

 ----

 = Danger Ahead! =
 This theme editor is provided as a convenience, but it is '''not the
 recommended way to modify a theme'''.

 One false move can render your '''whole site unusable'''. That means you
 won't even be able to come back here to undo what caused the error. You
 would need to restore a backup using FTP. If you don't know what FTP is,
 you probably should not be using this editor.

 Furthermore, even if everything goes well, as soon as the theme is
 updated, you will lose all the changes you have made.

 If you want to make small style changes, consider
 [https://wordpress.org/plugins/jetpack/ intalling Jetpack] and using its
 [https://jetpack.com/support/custom-css/ Custom CSS module]. It provides a
 better editor, keeps track of your changes, can not break your site and
 will keep your modifications when the theme is updated.

 If the changes you want to make are more substantial, the recommended
 approach is to [https://codex.wordpress.org/Child_Themes create your own
 child theme]. This will isolate your modifications and make sure they are
 retained when the original theme is updated.

 ''Primary button label:'' Back to safety
 ''Secondary button label:'' Just leave me alone, I know what to do

 ----

 Reference for the secondary button label:
 https://www.youtube.com/watch?v=nlbjnZbxEcI

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31779#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform