[wp-trac] [WordPress Trac] #24587: Walker_Page and Walker_Nav_Menu not compatible

WordPress Trac noreply at wordpress.org
Thu Aug 25 12:32:32 UTC 2016


#24587: Walker_Page and Walker_Nav_Menu not compatible
------------------------------------------+-----------------------------
 Reporter:  geardev                       |       Owner:  johnbillion
     Type:  defect (bug)                  |      Status:  accepted
 Priority:  normal                        |   Milestone:  Future Release
Component:  Menus                         |     Version:  3.0
 Severity:  normal                        |  Resolution:
 Keywords:  needs-patch needs-unit-tests  |     Focuses:
------------------------------------------+-----------------------------

Comment (by peterwilsoncc):

 In [attachment:24587-tests-enforce-object.2.diff], I've created some tests
 to enforce an $args object on filters within `Walker_Nav_Menu`.

 It's easy to see an oversight breaking backward compatibility here so I'd
 like to enforce it. Will commit after sitting on these tests for a few
 days. Further tests will be needed for the eventual solution.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/24587#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list