[wp-trac] [WordPress Trac] #37806: Attachment Details - Edit: uneven height between input field and "Scale" button

[WordPress Trac]

#37806: Attachment Details - Edit: uneven height between input field and "Scale"
button
--------------------------+------------------------
 Reporter:  eliorivero    |       Owner:  joemcgill
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  4.7
Component:  Media         |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  ui
--------------------------+------------------------
Changes (by joemcgill):

 * keywords:   => has-patch
 * owner:   => joemcgill
 * status:  new => accepted
 * milestone:  Awaiting Review => 4.7


Comment:

 Hi @eliorivero,

 Good catch, and thanks for contributing. Your patch seems to work well for
 the image edit view inside the media modal, but misses the same issue on
 the `/wp-admin/post.php?post={{post_id}}&action=edit` screen. The easiest
 way to get to that screen is from the list view in the media library.

 Looks like by removing the styles in your patch, the padding and line-
 height for these inputs fall back to the defaults set for any input inside
 a `.edit-attachment-frame` (see
 [https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/css/media.css#L783 relevant lines of code]), which explains why it's
 only being applied in the media modal.

 Perhaps we should apply the same default `padding` and `line-height` being
 applied to `.edit-attachment-frame input` and `.edit-attachment-frame
 textarea` to `.imgedit-settings input` and `.imgedit-settings textarea`.
 What do you think?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37806#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform