[wp-trac] [WordPress Trac] #18556: Toolbar dropdowns when dragging items

WordPress Trac noreply at wordpress.org
Mon Aug 22 16:15:36 UTC 2016


#18556: Toolbar dropdowns when dragging items
-------------------------------------+------------------------------
 Reporter:  chexee                   |       Owner:  drecodeam
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Toolbar                  |     Version:  3.2.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui
-------------------------------------+------------------------------
Changes (by akibjorklund):

 * keywords:  needs-refresh => has-patch needs-testing


Comment:

 I've attached
 [https://core.trac.wordpress.org/attachment/ticket/18556/18556.5.diff
 another attempt] to fix this. With a single selector I'm targeting all
 current draggables and sortables, so there is no need to add code to all
 event handlers. The patch also disables popup menus on the admin menu in
 addition to the toolbar, which is less of an issue but still.

 I'm using toggleClass on dragstart and dragstop instead of explicitly
 adding a class and removing it. This might cause issues state on some
 browsers if the events don't always fire in a predictable order, but it
 did work flawlessly on the ones I tested it with.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/18556#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list