[wp-trac] [WordPress Trac] #22363: Accents in attachment filenames should be sanitized

[WordPress Trac]

#22363: Accents in attachment filenames should be sanitized
--------------------------------------------------+------------------
 Reporter:  tar.gz                                |       Owner:
     Type:  defect (bug)                          |      Status:  new
 Priority:  normal                                |   Milestone:  4.7
Component:  Permalinks                            |     Version:  3.4
 Severity:  critical                              |  Resolution:
 Keywords:  needs-testing dev-feedback has-patch  |     Focuses:
--------------------------------------------------+------------------
Changes (by swissspidy):

 * keywords:  needs-testing dev-feedback => needs-testing dev-feedback has-
     patch


Comment:

 I'd really like to get this into 4.7.

 [attachment:22363.diff] makes the last patch apply cleanly against trunk
 again, so that should get us going. Worked well on my local install.

 Replying to [comment:64 chriscct7]:
 > From the core-images chat:
 > Marko:
 > > First thing I want to do is split the unit tests so it runs with and
 without PCRE. Secondly looking at what to do with
 sanitize_file_name_chars. New code almost completely ignores it. Which
 could be fine.
 >
 >
 > https://wordpress.slack.com/archives/core-images/p1455214794000335

 I agree with that. Unfortunately I'm not really familiar with all the PCRE
 stuff in PHP so I'd need some help there. IIRC @SergeyBiryukov has some
 knowledge there.

 Looking at an earlier comment, @miqrogroove and @pento should be quite
 familiar with the formatting component, which can't hurt either.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/22363#comment:75>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform