[wp-trac] [WordPress Trac] #37368: get_object_taxonomies() ignores output type argument for attachments

WordPress Trac noreply at wordpress.org
Sat Aug 20 17:29:24 UTC 2016


#37368: get_object_taxonomies() ignores output type argument for attachments
--------------------------------------+-----------------------
 Reporter:  Rarst                     |       Owner:
     Type:  defect (bug)              |      Status:  reopened
 Priority:  normal                    |   Milestone:  4.7
Component:  Taxonomy                  |     Version:  3.0
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+-----------------------
Changes (by boonebgorges):

 * keywords:  needs-unit-tests good-first-bug has-patch needs-testing =>
     good-first-bug has-patch
 * milestone:  Future Release => 4.7


Comment:

 @codemovement.pk Thank you for your patch! On review, I think we can
 reduce duplicated code and simplify the logic flow by updating
 `get_attachment_taxonomies()` so that it accepts an `$output` parameter
 just like `get_object_taxonomies()` does. I'm going to clean up your patch
 in this way.

 @deeptiboddapati I'll follow up on your comments in a subsequent comment.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37368#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list