[wp-trac] [WordPress Trac] #37630: WP_UnitTest_Factory_For_Attachment method for 'create' is not implemented

[WordPress Trac]

#37630: WP_UnitTest_Factory_For_Attachment method for 'create' is not implemented
------------------------------------+-------------------
 Reporter:  bcole808                |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  4.7
Component:  Build/Test Tools        |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  docs
------------------------------------+-------------------
Changes (by boonebgorges):

 * keywords:  has-patch => has-patch dev-feedback
 * focuses:   => docs
 * milestone:  Awaiting Review => 4.7


Comment:

 @bcole808 Thank you for the updated patch! The logic looks good to me. I
 have added some documentation to make it a bit clearer what's going on
 here.

 @DrewAPicture Could we please have a documentation review of
 [attachment:37630.3.diff]? Is the summary for `$args` clear enough (args
 get passed through to `wp_insert_post()`)? Is the `$legacy_` naming
 convention sufficient for deprecated params?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37630#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform