[wp-trac] [WordPress Trac] #37731: Infinite loop in _wp_json_sanity_check() during plugin install

[WordPress Trac]

#37731: Infinite loop in _wp_json_sanity_check() during plugin install
-------------------------------------------------+-------------------------
 Reporter:  maestrosite                          |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  4.6.1
Component:  Plugins                              |     Version:  4.6
 Severity:  normal                               |  Resolution:
 Keywords:  dev-feedback has-patch needs-        |     Focuses:
  testing                                        |  administration
-------------------------------------------------+-------------------------
Changes (by swissspidy):

 * keywords:  dev-feedback => dev-feedback has-patch needs-testing
 * milestone:  Awaiting Review => 4.6.1


Comment:

 Props to ionutst for working on his first WordPress patch to fix this
 issue.

 As one can see from [attachment:37731.diff], after [37444] the JSON data
 wasn't sanitized anymore before going through `_wp_json_sanity_check()`.
 Probably because of false assumptions in #36358, but maybe @rmccue can
 quickly chime in here.


 Adding to the 4.6.1 milestone for now as an infinite loop is a pretty bad
 error. There are tests for `wp_json_encode()` but unfortunately they
 didn't catch it as it depends on server environment and the function's
 arguments.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37731#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform