[wp-trac] [WordPress Trac] #37616: Replace `is_super_admin()` calls with real capability checks

[WordPress Trac]

#37616: Replace `is_super_admin()` calls with real capability checks
-----------------------------+------------------------
 Reporter:  flixos90         |       Owner:
     Type:  task (blessed)   |      Status:  new
 Priority:  normal           |   Milestone:  4.7
Component:  Role/Capability  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:                   |     Focuses:  multisite
-----------------------------+------------------------

Comment (by Presskopp):

 We should probably create a list of occurrences

 At your service:

 {{{
 Search "is_super_admin()" (32 hits in 18 files)

 ...\wp-admin\edit-form-advanced.php (1 hit)
         Line 311:       if ( is_super_admin() || current_user_can(
 $post_type_object->cap->edit_others_posts ) )

 ...\wp-admin\includes\ajax-actions.php (1 hit)
         Line 251:       if ( ! is_super_admin() && ! apply_filters(
 'autocomplete_users_for_site_admins', false ) )

 ...\wp-admin\includes\class-wp-posts-list-table.php (1 hit)
         Line 1407:                      if ( is_super_admin() ||
 current_user_can( $post_type_object->cap->edit_others_posts ) ) :

 ...\wp-admin\includes\ms.php (2 hits)
         Line 690:       if ( !is_super_admin() )
         Line 759:       if ( ! is_super_admin() ) {

 ...\wp-admin\menu.php (1 hit)
         Line 31: if ( ! is_multisite() || is_super_admin() )

 ...\wp-admin\network.php (1 hit)
         Line 18: if ( ! is_super_admin() ) {

 ...\wp-admin\options-general.php (2 hits)
         Line 344:
 'show_available_translations' => ( ! is_multisite() || is_super_admin() )
 && wp_can_install_language_pack(),
         Line 349:                               if ( is_super_admin() ) {

 ...\wp-admin\options.php (3 hits)
         Line 77: if ( is_multisite() && ! is_super_admin() && 'update' !=
 $action ) {
         Line 163:               if ( is_multisite() && ! is_super_admin()
 )
         Line 184:               if ( ! empty( $_POST['WPLANG'] ) && ( !
 is_multisite() || is_super_admin() ) ) { // @todo: Skip if already
 installed

 ...\wp-admin\user-new.php (3 hits)
         Line 40:                if ( is_super_admin() ) {
         Line 221:       && ( is_super_admin() || apply_filters(
 'autocomplete_users_for_site_admins', false ) )
         Line 309:       if ( !is_super_admin() ) {

 ...\wp-admin\users.php (3 hits)
         Line 125:                       && ! ( is_multisite() &&
 is_super_admin() ) ) {
         Line 324:               if ( $id == $current_user->ID &&
 !is_super_admin() ) {
         Line 380:               if ( $id == $current_user->ID &&
 !is_super_admin() ) {


 ...\wp-includes\admin-bar.php (4 hits)
         Line 286:       if ( ! is_user_member_of_blog() && !
 is_super_admin() )
         Line 383:       if ( count( $wp_admin_bar->user->blogs ) < 1 && !
 is_super_admin() )
         Line 398:       if ( is_super_admin() ) {
         Line 454:                       'class' => is_super_admin() ? 'ab-
 sub-secondary' : '',

 ...\wp-includes\capabilities.php (1 hit)
         Line 366:                       // update_, install_, and delete_
 are handled above with is_super_admin().

 ...\wp-includes\link-template.php (1 hit)
         Line 3479:      if ( ! is_super_admin() && empty($blogs) ) {

 ...\wp-includes\ms-deprecated.php (3 hits)
         Line 58:  * @deprecated 3.0.0 Use is_super_admin()
         Line 59:  * @see is_super_admin()
         Line 64:        _deprecated_function( __FUNCTION__, '3.0.0',
 'is_super_admin()' );

 ...\wp-includes\ms-functions.php (1 hit)
         Line 579:       if ( strlen( $blogname ) < 4 && !is_super_admin()
 )

 ...\wp-includes\ms-load.php (1 hit)
         Line 84:        if ( is_super_admin() )

 ...\wp-includes\option.php (2 hits)
         Line 797:       if ( is_super_admin() && !
 is_user_member_of_blog() ) {
         Line 961:       if ( is_super_admin() && !
 is_user_member_of_blog() ) {


 ...\wp-signup.php (1 hit)
         Line 825: if ( is_super_admin() ) {

 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37616#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform