[wp-trac] [WordPress Trac] #37708: `wp_http_supports()` doesn't reflect what Requests can do

WordPress Trac noreply at wordpress.org
Thu Aug 18 04:36:48 UTC 2016


#37708: `wp_http_supports()` doesn't reflect what Requests can do
--------------------------+-------------------------
 Reporter:  dd32          |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  4.7
Component:  HTTP API      |    Version:  4.6
 Severity:  normal        |   Keywords:  needs-patch
  Focuses:                |
--------------------------+-------------------------
 While reviewing what parts of `WP_HTTP` can be removed in #37705, I
 noticed that `wp_http_supports()` still performs it's checks against the
 `WP_HTTP` transports rather than querying against Requests to see if the
 request can be performed or not.

 The only capability which we supported was `ssl`.

 Three options:
 1. Query SSL ability against Requests (if it supports that)
 1. Deprecate and always `return true;`
 1. Implement a small check to see if SSL requests will be able to proceed,
 checking for cURL features or openssl being available (and all the other
 streams requirements being satisfied).

 The above options are in my order of preferences, we should support it if
 possible, but I'm not afraid of just no-oping the function.

 Marking for 4.7, with the potential for 4.6.x backporting.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37708>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list