[wp-trac] [WordPress Trac] #33885: meta_form performs a potentially expensive query

[WordPress Trac]

#33885: meta_form performs a potentially expensive query
-------------------------------------+-----------------------------
 Reporter:  jorbin                   |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  Administration           |     Version:  4.3.1
 Severity:  critical                 |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  performance
-------------------------------------+-----------------------------

Comment (by dd32):

 Replying to [comment:38 jb510]:
 > Why avoid altering the table here? Is the concern someone could be using
 a 191+ char key and updating could truncate the key? Could we check max
 field length and then update?   Or are we hoping for an upstream fox from
 MariaDB?

 Ideally MySQL/MariaDB/whomever else fixes whatever the bug is that we're
 running into.

 We can't really decrease the length of the column, mostly due to problems
 arising from truncating keys, but also because it adds unexpected limits
 to the key lengths which have existed this way for quite some time. Having
 a shorter index is really a bandaid to allow it to work over all hosts.

 Ideally I think we're probably best removing this metabox query entirely,
 and moving towards something else. We could leverage the meta registration
 process for example for pre-filling the meta keys without a query or
 somesuch too (or just remembering the last //x// meta_keys used by users
 in a transient or option)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33885#comment:39>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform