[wp-trac] [WordPress Trac] #37669: Shiny Updates: Cancelling the filesystem credentials when updating within the pop-up prevents updating again (without closing/opening) and leaves UI artefacts (was: Shiny updates bug (WP 4.6 RC 3): Cancelling the filesystem credentials when updating within the pop-up prevents updating again (without closing/opening) and leaves UI artefacts)

[WordPress Trac]

#37669: Shiny Updates: Cancelling the filesystem credentials when updating within
the pop-up prevents updating again (without closing/opening) and leaves UI
artefacts
---------------------------+-----------------------------------------
 Reporter:  DavidAnderson  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Themes         |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  needs-patch    |     Focuses:  javascript, administration
---------------------------+-----------------------------------------
Changes (by ocean90):

 * keywords:   => needs-patch
 * focuses:  javascript => javascript, administration
 * component:  Upgrade/Install => Themes


Old description:

> Reproducible on RC3: 4.6-RC3-38260
>
> Reproducible: every time
>
> Steps to reproduce:
>
> 1) Set up WordPress, and set permissions to that the 'filesystem
> credentials' dialog will be required when performing theme updates.
>
> 2) Tweak a version number so that you will have a theme that needs an
> update. Then, go to /wp-admin/themes.php
>
> 3) Do *not* click on the immediately visible "Update now". Instead, click
> on the theme such that the pop-up pops up.
>
> 4) Click on the "Update now" link within the pop-up. If step 1) was done
> correctly, then the filesystem dialog should now pop up.
>
> 5) Close the filesystem credentials dialog.
>
> Result: "Updating..." will still show there. But nothing will be
> updating. You cannot update until you close the pop-up and re-open it.
>
> Excepted result: The "update now" link re-appears, and "Updating.."
> disappears.
>
> Result: nothing happens.
>
> #32785 is similar, but a separate (and now fixed) issue.

New description:

 Reproducible on RC3: 4.6-RC3-38260

 Reproducible: every time

 Steps to reproduce:

 1) Set up WordPress, and set permissions to that the 'filesystem
 credentials' dialog will be required when performing theme updates.

 2) Tweak a version number so that you will have a theme that needs an
 update. Then, go to /wp-admin/themes.php

 3) Do *not* click on the immediately visible "Update now". Instead, click
 on the theme such that the pop-up pops up.

 4) Click on the "Update now" link within the pop-up. If step 1) was done
 correctly, then the filesystem dialog should now pop up.

 5) Close the filesystem credentials dialog.

 Result: "Updating..." will still show there. But nothing will be updating.
 You cannot update until you close the pop-up and re-open it.

 Excepted result: The "update now" link re-appears, and "Updating.."
 disappears.

 Result: nothing happens.

 #37285 is similar, but a separate (and now fixed) issue.

--

Comment:

 Confirmed, see [attachment:37669.gif].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37669#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform