[wp-trac] [WordPress Trac] #37658: Featured image on media files can not be changed

[WordPress Trac]

#37658: Featured image on media files can not be changed
--------------------------------------+------------------------------
 Reporter:  Clorith                   |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Post Thumbnails           |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  javascript
--------------------------------------+------------------------------

Comment (by ocean90):

 I looked through the code base and found three similar checks:

 * https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/includes/image.php?rev=37488&marks=136,139#L134
 * https://core.trac.wordpress.org/browser/trunk/src/wp-admin/edit-form-
 advanced.php?rev=38029&marks=58,61,63#L57
 * https://core.trac.wordpress.org/browser/trunk/src/wp-
 includes/media.php?rev=38086&marks=3328,3331,3333#L3327

 All of them are using an additional `current_theme_supports()` check. This
 is missing in [38118] and [attachment:37658.2.diff]. Based on [27657] we
 should check for both right?

 /cc: @wonderboymusic

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37658#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform