[wp-trac] [WordPress Trac] #37664: Editing plugin isn't selected in the dropdown menu

[WordPress Trac]

#37664: Editing plugin isn't selected in the dropdown menu
--------------------------+------------------------------------------------
 Reporter:  wzislam       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Plugins       |     Version:  2.8
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  ui, accessibility, administration
  needs-testing           |
--------------------------+------------------------------------------------
Changes (by Clorith):

 * keywords:   => has-patch needs-testing
 * version:  4.5.3 => 2.8
 * milestone:  Awaiting Review => Future Release


Comment:

 The "inactive" bit is added if the plugin isn't enabled on your site (this
 is incorrectly reported when using anything but the primary file for the
 same reason the drop down is incorrect).

 The drop down relies on recognizing the plugin it belongs to, but we don't
 actually have a fixed query arg to identify the active plugin by (we
 change these depending on what file is viewed and the order in which you
 click on them.

 We are currently incorrectly overwriting the `plugin` query arg with the
 `file` (introduced in r11500)

 Attached patch, 37664.2.patch, removes the conditional, and ensures we
 don't accidentally pass over the remaining `$plugin` variable check by at
 some point (as it's not explicitly declared in the actual file before this
 point).

 It also updates the URLs used throughout the page to include
 `plugin=$plugin` since we no longer override this variable with the
 current filename at the start of the file.

 Will probably need some more testing, but so far not noticed any incorrect
 behavior.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37664#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform