[wp-trac] [WordPress Trac] #37554: update last checked time does not match the system time

[WordPress Trac]

#37554: update last checked time does not match the system time
-------------------------------------------------+-------------------------
 Reporter:  ctienshi                             |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Upgrade/Install                      |  Review
 Severity:  normal                               |     Version:  3.1
 Keywords:  dev-feedback has-screenshots has-    |  Resolution:
  patch                                          |     Focuses:  ui
-------------------------------------------------+-------------------------
Changes (by swissspidy):

 * keywords:  needs-patch dev-feedback has-screenshots => dev-feedback has-
     screenshots has-patch
 * version:  4.5.3 => 3.1


Comment:

 The line in question on `update-core.php` simply prints the '''current
 time''' and is actually quite useless:

 {{{#!php
 printf( __( 'Last checked on %1$s at %2$s.' ), date_i18n( __( 'F j, Y' )
 ), date_i18n( __( 'g:i a' ) ) );
 }}}

 I would rather remove that information instead of fixing it.

 [attachment:37554.patch] doesn't work as it doesn't respect the current
 timezone / GMT offset and passes `true` to `date_i18n` instead of `false`.
 [attachment:37554.diff] fixes that. However, it's only a minor improvement
 as it's basically still the current date, but now can be 60 seconds off.
 That's probably why simply the current date was displayed (or perhaps the
 right data hasn't been available, idk).

 Introduced in [15996].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37554#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform