[wp-trac] [WordPress Trac] #37620: Give us a bit help, with IS_ADMIN and IS_LOGIN

[WordPress Trac]

#37620: Give us a bit help, with IS_ADMIN and IS_LOGIN
--------------------------+-----------------------------
 Reporter:  tazotodua     |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  General       |    Version:
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 well, i had a ticket already opened, by was closed as dublicate.

 however, it was not a duplicate..

 what will WP loose, if you add this feature to core?
 However, developers will have a great help...

 now, i wish, that in wp-login.php, there was defined a variable like this:
 `define('WP_LOGIN_is_executed',true);`

 so, if that constant is defined, that means i am on wp-login page..
 WHY?  because 10000s of users use "hide-login-page" feature (i.e. iThemes
 security or other plugins), so URLs are no-longer `example.com/wp-
 login.php` and `pagenow`=='wp-login.php' returns false!

 same for ID_ADMIN()... those plugins have feature to hide-admin-url, thus,
 `wp-admin` are no longer accessible, that make `is_admin()` to return
 false..

 thus, WHAT ON EARTH, if you simply put:
 `define("WP_ADMIN_page_executed", true);`

 so, everyone will have a solution, with checking those constants, instead
 of URL comparisons and etc..

 i am exhausting to quarrel with skeptics, who always say "why that's
 needed"...
 ok, you dont need, but we NEED, so is that hard to update that?


 thanks for understanding.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37620>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform