[wp-trac] [WordPress Trac] #37615: Do not pass `$site` and `$network` by reference in `get_*()` functions

WordPress Trac noreply at wordpress.org
Tue Aug 9 18:12:49 UTC 2016


#37615: Do not pass `$site` and `$network` by reference in `get_*()` functions
--------------------------------+-------------------------
 Reporter:  flixos90            |       Owner:  jeremyfelt
     Type:  defect (bug)        |      Status:  closed
 Priority:  normal              |   Milestone:  4.6
Component:  Networks and Sites  |     Version:  trunk
 Severity:  normal              |  Resolution:  fixed
 Keywords:  has-patch           |     Focuses:  multisite
--------------------------------+-------------------------
Changes (by jeremyfelt):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"38233"]:
 {{{
 #!CommitTicketReference repository="" revision="38233"
 Multisite: Remove unnecessary reference parameters.

 There is no advantage to passing parameters by reference to `get_site()`,
 `get_network()`, and `update_site_cache()`.

 Merge of [38232] to the 4.6 branch.

 Props flixos90, ocean90 for review.
 Fixes #37615.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37615#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list