[wp-trac] [WordPress Trac] #37615: Do not pass `$site` and `$network` by reference in `get_*()` functions

WordPress Trac noreply at wordpress.org
Tue Aug 9 16:36:04 UTC 2016


#37615: Do not pass `$site` and `$network` by reference in `get_*()` functions
--------------------------------+-------------------------
 Reporter:  flixos90            |       Owner:  jeremyfelt
     Type:  defect (bug)        |      Status:  accepted
 Priority:  normal              |   Milestone:  4.6
Component:  Networks and Sites  |     Version:  trunk
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |     Focuses:  multisite
--------------------------------+-------------------------
Changes (by jeremyfelt):

 * owner:   => jeremyfelt
 * status:  new => accepted


Comment:

 Looks good. I don't think there's a reason for us to pass by reference
 here. I'm going to hold off on committing to trunk until we're good for
 4.6 as well. Pinging @ocean90 for review. :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37615#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list