[wp-trac] [WordPress Trac] #37603: Missing visual feedback when deleting themes/plugins

[WordPress Trac]

#37603: Missing visual feedback when deleting themes/plugins
-----------------------------+---------------------------------------------
 Reporter:  ocean90          |       Owner:  jorbin
     Type:  defect (bug)     |      Status:  reviewing
 Priority:  normal           |   Milestone:  4.6
Component:  Plugins          |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:  ui, javascript, administration
  commit                     |
-----------------------------+---------------------------------------------
Changes (by ocean90):

 * keywords:  has-patch => has-patch commit
 * owner:  ocean90 => jorbin


Comment:

 [attachment:37603.4.diff] renames `$message` to `$link` and changes

 {{{#!js
 if ( 'update-theme' === job.action ) {
         $message = $( '[data-slug="' + job.data.slug + '"]' ).find(
 '.update-message' );
 } else if ( 'delete-theme' === job.action ) {
         if ( 'themes-network' === pagenow ) {
                 $message = $( '[data-slug="' + job.data.slug + '"]'
 ).find( '.row-actions a.delete' );
         } else {
                 $message = $( '.theme-actions .delete-theme' );
         }
 }
 }}}

 to

 {{{#!js
 if ( 'update-theme' === job.action ) {
         $message = $( '[data-slug="' + job.data.slug + '"]' ).find(
 '.update-message' );
 } else if ( 'delete-theme' === job.action && 'themes-network' === pagenow
 ) {
         $message = $( '[data-slug="' + job.data.slug + '"]' ).find( '.row-
 actions a.delete' );
 } else if ( 'delete-theme' === job.action && 'themes' === pagenow ) {
         $message = $( '.theme-actions .delete-theme' );
 }
 }}}

 which makes it more readable IMO.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37603#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform