[wp-trac] [WordPress Trac] #37605: Change `private` member access to `protected` in `MakePOT` class

[WordPress Trac]

#37605: Change `private` member access to `protected` in `MakePOT` class
------------------------------+-----------------------------
 Reporter:  jdgrimes          |      Owner:
     Type:  defect (bug)      |     Status:  new
 Priority:  normal            |  Milestone:  Awaiting Review
Component:  Build/Test Tools  |    Version:  trunk
 Severity:  normal            |   Keywords:
  Focuses:                    |
------------------------------+-----------------------------
 In [36752] ([https://i18n.trac.wordpress.org/changeset/40327/ i18n40327])
 visibility keywords were added to the properties and methods of the
 `MakePOT` class, which is bundled with trunk in `tools/i18n/makepot.php`.
 Mostly these were made `public`, however, some were not intended to be
 public (but previously were do to lack of any visibility restrictions) and
 so were made `private`. This will break any [https://github.com/WordPoints
 /dev-lib/blob/develop/i18n/makepot.php child class] that might be
 attempting to use these properties/methods. It would be better if these
 were changed to `protected`, rather than `private`, especially considering
 that they were made freely public before. Otherwise code that expected the
 prior behavior not only breaks, but has no real work-around either (other
 than just copying those methods and properties to the child class, or
 continuing to use the
 [https://i18n.trac.wordpress.org/browser/tools/branches/legacy legacy
 version]).

 ([https://wordpress.slack.com/archives/core/p1470682991002408 Discussion
 in #core channel on Slack] prior to making this ticket.)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37605>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform