[wp-trac] [WordPress Trac] #37504: Update message displays unstyled in plugins list

[WordPress Trac]

#37504: Update message displays unstyled in plugins list
----------------------------------------------+----------------------------
 Reporter:  ovann86                           |       Owner:  DrewAPicture
     Type:  defect (bug)                      |      Status:  reviewing
 Priority:  normal                            |   Milestone:  4.6
Component:  Plugins                           |     Version:  trunk
 Severity:  normal                            |  Resolution:
 Keywords:  has-patch has-screenshots commit  |     Focuses:  ui,
                                              |  administration
----------------------------------------------+----------------------------
Changes (by ocean90):

 * keywords:  has-patch has-screenshots => has-patch has-screenshots commit


Comment:

 Replying to [comment:17 helen]:
 > I'm not sure I understand why the `:not(.notice)` selectors are
 necessary. Also, since there are different notice styles, please test and
 make sure that the colors can still be overridden by those classes (e.g.
 `.notice-info`).

 HTML markup of a table row for an update in…

 …WordPress 4.5:
 {{{#!htm
 <tr class="plugin-update-tr active" id="hello-dolly-update" data-slug
 ="hello-dolly" data-plugin="hello.php">
         <td colspan="3" class="plugin-update colspanchange">
                 <div class="update-message"> <!-- This element needs to be
 addressed. -->
                         There is a new version of Hello Dolly available.
 <a href="" class="thickbox open-plugin-details-modal" aria-label="View
 Hello Dolly version 1.6 details">View version 1.6 details</a> or <a
 href="" class="update-link" aria-label="Update Hello Dolly now">update
 now</a>.
                 </div>
         </td>
 </tr>
 }}}

 …trunk:
 {{{#!htm
 <tr class="plugin-update-tr" id="hello-dolly-update" data-slug="hello-
 dolly" data-plugin="hello-dolly/hello.php">
         <td colspan="3" class="plugin-update colspanchange">
                 <div class="update-message notice inline notice-warning
 notice-alt">
                         <p>
                                 There is a new version of Hello Dolly
 available. <a href="" class="thickbox open-plugin-details-modal" aria-
 label="View Hello Dolly version 1.6 details">View version 1.6 details</a>
 or <a href="" class="update-link" aria-label="Update Hello Dolly
 now">update now</a>.
                         </p>
                 </div>
         </td>
 </tr>
 }}}

 By using `:not(.notice)` we only address the element which has the
 `.update-message` class, no other notice classes are involved.
 To make this clearer we could use another selector: `div[class="update-
 message"]`, see [attachment:37504.4.patch].


 Proposing [attachment:37504.3.patch] or [attachment:37504.4.patch] for
 commit.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37504#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform