[wp-trac] [WordPress Trac] #37583: Shiny Updates: Enhance error reporting when response is invalid

[WordPress Trac]

#37583: Shiny Updates: Enhance error reporting when response is invalid
-------------------------------------+-------------------------------------
 Reporter:  ocean90                  |       Owner:  azaozz
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  4.6
Component:  Upgrade/Install          |     Version:  trunk
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-patch has-           |     Focuses:  ui, javascript,
  screenshots commit                 |  administration
-------------------------------------+-------------------------------------
Changes (by ocean90):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"38205"]:
 {{{
 #!CommitTicketReference repository="" revision="38205"
 Update/Install: Replace "error" and "-1" failure messages with a more
 meaningful one.

 * "-1" is an invalid nonce error, show 'An error has occurred. Please
 reload the page and try again.'.
 * "error" means that the connection to the server was lost, show
 'Connection lost or the server is busy. Please try again later.'.
 * Escape the message in `wp-updates-admin-notice` because the response may
 include HTML.
 * Remove HTML tags in `wp.updates.isValidResponse()` to make PHP's error
 messages more readable.

 Props azaozz for review.
 Fixes #37583.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37583#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform