[wp-trac] [WordPress Trac] #37575: Customizer Menus: css selector missing when adding custom link

[WordPress Trac]

#37575: Customizer Menus: css selector missing  when adding custom link
--------------------------+------------------------------
 Reporter:  virgodesign   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Customize     |     Version:  4.5.3
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------

Comment (by vishalkakadiya):

 Ok then quick review for `Core Committers`,

 Checked `customize-nav-menus.js` Line no `1323`
 where we add class `'menu-item-' + settingValue.object`, But the thing is
 that when custom menu link add to menu `_submitLink()` is called which is
 internally call `submitLink()`

 So in `submitLink()` there are one `menuItem` variable which `'object':
 ''`, but at that place we need to replace `'object': 'custom'` sting in
 place of null string.

 So that in `'menu-item-' + settingValue.object` which will generate class
 name as `menu-item-custom`

 Let me know if anything still needed.

 Thanks.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37575#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform