[wp-trac] [WordPress Trac] #37531: Plugin installation failure not reflected in the UI

[WordPress Trac]

#37531: Plugin installation failure not reflected in the UI
-------------------------------------+---------------------------------
 Reporter:  AronMS                   |       Owner:  ocean90
     Type:  defect (bug)             |      Status:  assigned
 Priority:  high                     |   Milestone:  4.6
Component:  Plugins                  |     Version:  trunk
 Severity:  major                    |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:  ui, administration
-------------------------------------+---------------------------------

Comment (by ocean90):

 [attachment:37531.7.diff] removes `$status['errorCode'] =
 $wp_filesystem->errors->get_error_code();` from all four Ajax handlers.
 Filesystem errors related to auth/connect  ('no_ftp_ext',
 'empty_hostname', 'empty_username', 'empty_password', 'connect', 'auth',
 'no_ssh2_ext', 'ssh2_php_requirement') should always be visible in the
 modal which gets only opened when the error code is
 `unable_to_connect_to_filesystem`.

 This was added in [attachment:37531.patch] but the change to `wp-
 admin/js/updates.js` is the better fix for this.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37531#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform