[wp-trac] [WordPress Trac] #36795: Customize: Improve flow from menu locations to editing a menu

WordPress Trac noreply at wordpress.org
Thu Aug 4 02:13:08 UTC 2016


#36795: Customize: Improve flow from menu locations to editing a menu
-------------------------------------------------+-------------------------
 Reporter:  celloexpressions                     |       Owner:
     Type:  enhancement                          |  westonruter
 Priority:  normal                               |      Status:  reopened
Component:  Customize                            |   Milestone:  4.6
 Severity:  normal                               |     Version:  4.3
 Keywords:  has-patch has-screenshots i18n-      |  Resolution:
  change commit                                  |     Focuses:  ui,
                                                 |  accessibility
-------------------------------------------------+-------------------------
Changes (by celloexpressions):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 As @afercia suggested in [comment:25], we need to provide padding on the
 link so that it is accessible to touch users. This would also improve the
 legibility of the focus style. [38189] is a usability regression for touch
 users.

 My suggestion would be to do this with `line-height` instead of `padding`,
 as that should provide more reliable/consistent results than `vertical-
 align: middle`. This allows us to match the explictily-defined `28px`
 height of the adjacent select element.

 [attachment:36795.4.diff] also adjusts the font-size to match the `14px`
 of the select element and customize control title, although that part is
 more subjective and could be excluded for 4.6. Arguments could be made for
 either `13px` or `14px`, but it seems like it should match the font in the
 select next to it and the title directly above it rather than the section
 description up above.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36795#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list