[wp-trac] [WordPress Trac] #37561: Inserting rewrite rules using the filter 'option_rewrite_rules' breaks 'WP_Rewrite::flush_rules()', causing 404 errors

[WordPress Trac]

#37561: Inserting rewrite rules using the filter 'option_rewrite_rules' breaks
'WP_Rewrite::flush_rules()', causing 404 errors
---------------------------+------------------------------
 Reporter:  maratbn        |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Rewrite Rules  |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:                 |     Focuses:
---------------------------+------------------------------

Comment (by dd32):

 The `option_rewrite_rules` filter really isn't the right place to add
 rewrite rules, and IMHO makes this an invalid approach that makes this a
 Gravity Forms bug more so than a core issue.

 The proper way would be to filter on `rewrite_rules_array` or use
 `add_rewrite_rule()` (probably with the  3rd arg set to`top`).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37561#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform