[wp-trac] [WordPress Trac] #37556: Shiny Updates: aria-label not updated on failure on plugins.php

WordPress Trac noreply at wordpress.org
Wed Aug 3 22:14:03 UTC 2016


#37556: Shiny Updates: aria-label not updated on failure on plugins.php
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  4.6
Component:  Plugins                  |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  accessibility,
  patch commit                       |  javascript
-------------------------------------+-------------------------------------

Comment (by afercia):

 Note: during testing after the weekly dev chat @ocean90 noticed also other
 places where removing the `aria-label` would be appropriate because the
 element text is clear enough. He's kindly updating the patch :) Worth
 noting using the same text for both the element's text and the `aria-
 label` is a bit pointless and can be safely avoided. For example doing
 this on the same element:

 {{{
 .attr( 'aria-label', wp.updates.l10n.updateFailedShort )
 ...
 .text( wp.updates.l10n.updateFailedShort );
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37556#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list