[wp-trac] [WordPress Trac] #37531: Plugin installation failure not reflected in the UI

[WordPress Trac]

#37531: Plugin installation failure not reflected in the UI
-------------------------------------+---------------------------------
 Reporter:  AronMS                   |       Owner:  obenland
     Type:  defect (bug)             |      Status:  reviewing
 Priority:  high                     |   Milestone:  4.6
Component:  Plugins                  |     Version:  trunk
 Severity:  major                    |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, administration
-------------------------------------+---------------------------------

Comment (by ocean90):

 Replying to [comment:18 obenland]:
 > Patch looks good. I noticed that when it checks for
 `$skin->get_errors()->get_error_code()` in the ajax callbacks, it doesn't
 add the error code to the response, is that by design?

 In this branch we may have multiple errors and `get_error_code()` would
 only return the error code for the first error message. I'm fine with
 adding it there though because during tests I wasn't really able to
 trigger more than one error in the same process.

 Patch needs an update because I copied the wrong DocBlock to
 `__construct()`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37531#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform