[wp-trac] [WordPress Trac] #33372: WP_Query may return incorrect results when using negative values with parameter p.

[WordPress Trac]

#33372: WP_Query may return incorrect results when using negative values with
parameter p.
-------------------------------------------------+-------------------------
 Reporter:  giantrobot                           |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Future
Component:  Query                                |  Release
 Severity:  normal                               |     Version:
 Keywords:  good-first-bug has-patch has-unit-   |  Resolution:
  tests                                          |     Focuses:
-------------------------------------------------+-------------------------

Comment (by kouratoras):

 Replying to [comment:22 Akeif]:
 > @kouratoras I upload the new patch `33372_4.diff`. Let me know what you
 think :)

 I have 2 comments:
 - `is_object()` is not needed, as it's covered by `! is_scalar()`
 - We should remove `$this->assertSame( -3, $q->query_vars['p'] );` from
 unit test, as in this case it is 0.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33372#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform