[wp-trac] [WordPress Trac] #37531: Plugin installation failure not reflected in the UI

[WordPress Trac]

#37531: Plugin installation failure not reflected in the UI
-------------------------------------+---------------------------------
 Reporter:  AronMS                   |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  high                     |   Milestone:  4.6
Component:  Plugins                  |     Version:  trunk
 Severity:  major                    |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, administration
-------------------------------------+---------------------------------
Changes (by ocean90):

 * keywords:  needs-patch => has-patch needs-testing


Comment:

 [attachment:37531.5.patch]:

 * Includes [attachment:37531.3.diff] without `class-wp-upgrader.php`
 change
 * Includes [attachment:37531.4.diff]
 * Introduces `WP_Ajax_Upgrader_Skin` which extends
 `Automatic_Upgrader_Skin`. This class stores all error messages/WP_Error
 objects in an `$error` property.
 * All Ajax handlers are updated to use the new skin.
 * Each Ajax handler now checks for the 3 error sources: 1) Result of the
 install/update method, 2) `$skin->result` and 3) `$skin->get_errors()`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37531#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform