[wp-trac] [WordPress Trac] #36795: Customize: Improve flow from menu locations to editing a menu

[WordPress Trac]

#36795: Customize: Improve flow from menu locations to editing a menu
-------------------------------------------------+-------------------------
 Reporter:  celloexpressions                     |       Owner:
     Type:  enhancement                          |  westonruter
 Priority:  normal                               |      Status:  reviewing
Component:  Customize                            |   Milestone:  4.6
 Severity:  normal                               |     Version:  4.3
 Keywords:  has-patch has-screenshots i18n-      |  Resolution:
  change ui-feedback                             |     Focuses:  ui,
                                                 |  accessibility
-------------------------------------------------+-------------------------
Changes (by celloexpressions):

 * keywords:  has-patch has-screenshots commit i18n-change => has-patch has-
     screenshots i18n-change ui-feedback


Comment:

 We should absolutely add an `aria-label`. I think the title of the
 selected menu may also be useful here, although it presumably would have
 just been read out with the selected control. It would also need to be
 updated when the title is edited and that starts to get a bit messy.

 I'm hesitant to change anything visually here at this point. We're in RC,
 and this is the first time it's come up as an issue in 5 weeks. Granted
 there hasn't been a lot of feedback here to date in general; it isn't
 really "broken" visually, but we could perhaps try something different.
 CSS changes this late should be avoided unless absolutely necessary due to
 the likelihood of inadvertently breaking something.

 I agree that the placement and styling of the button could lead users to
 think that it's meant to submit something. However, there aren't many
 inputs in the customizer that have submit buttons next to them, and
 clicking to edit the menu isn't the end of the world and could even be
 argued as expected "submit" behavior given the way things work in the
 customizer. The flow is to select a menu, then edit it as it becomes
 visible in the preview at the same time.

 In terms of the visual appearance of this as an underlined link, I'm not a
 fan. The contrast is quantitatively low (and primary actionable UI like
 this should generally have higher contrast that regular text, etc.), the
 font size is extremely small (especially with the native Windows font),
 and the underline combined with the small font size and the short width of
 the word (in English at least) make it quite difficult to read. It looks
 like we're trying to hide the fact that there's UI here.

 Brief aside: the accessibility team should probably follow the UI focus to
 track everything that changes UI, and use the accessibility focus for
 tickets focused primarily on accessibility. Otherwise, the two focuses are
 redundant.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36795#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform