[wp-trac] [WordPress Trac] #37531: Plugin installation failure not reflected in the UI

[WordPress Trac]

#37531: Plugin installation failure not reflected in the UI
--------------------------+---------------------------------
 Reporter:  AronMS        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  4.6
Component:  Plugins       |     Version:  trunk
 Severity:  major         |  Resolution:
 Keywords:  needs-patch   |     Focuses:  ui, administration
--------------------------+---------------------------------

Comment (by flixos90):

 [attachment:37531.diff] fixes the `modal-open` class to be used. If the
 filesystem credentials modal isn't printed out, do not attempt to show it.
 (sorry about the stripped-out trailing spaces, I just noticed my code
 editor removed them)

 However, another problem here is that the directory already existing is
 actually not a filesystem credential error IMO. Even on a setup which
 allows direct filesystem access, this problem may appear - requesting
 filesystem credentials wouldn't fix it. Therefore, in
 [attachment:37531.2.diff] I modified the upgrader class to store this
 specific error in the `$result` property so that it is used by the AJAX
 function `wp_ajax_install_plugin()`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37531#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform