[wp-trac] [WordPress Trac] #35457: Theme installer upload button improvements

[WordPress Trac]

#35457: Theme installer upload button improvements
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:  afercia
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.6
Component:  Themes                   |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-           |     Focuses:  ui, accessibility,
  screenshots ui-feedback            |  javascript
-------------------------------------+-------------------------------------

Comment (by afercia):

 Replying to [comment:7 obenland]:
 > I'm not sure if we need that to maintain the browser history
 I'm not sure the "upload" route is working as intended. When browsing
 themes clicking on "Featured Popular Latest Favorites" these views get
 added to the browser's history. In fact, clicking the browser's "back" and
 "forward" buttons, works. But when clicking on the upload button, the
 history breaks. Seems it always worked this way.

 Maybe I'm missing something but I don't see what this "upload" route
 should actually do. It would be great to have a closer look at this by
 someone more expert than me with this kind of things.

 Personally, I'd be in favor of removing it and just let the upload button
 be a toggle. This way browser's history won't break. Also, I wouldn't hide
 the theme previews.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35457#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform