[wp-trac] [WordPress Trac] #30618: Clean up Customizer Media Control CSS (was: Media in the Customizer design bugs)

[WordPress Trac]

#30618: Clean up Customizer Media Control CSS
---------------------------------------+------------------
 Reporter:  celloexpressions           |       Owner:
     Type:  enhancement                |      Status:  new
 Priority:  normal                     |   Milestone:  4.6
Component:  Customize                  |     Version:  4.1
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:  ui
---------------------------------------+------------------
Changes (by celloexpressions):

 * keywords:  needs-patch => has-patch has-screenshots
 * type:  defect (bug) => enhancement
 * milestone:  Future Release => 4.6


Comment:

 Forgot this ticket existed, but these issues are still fixable. In
 [attachment:30618.diff]:
 - Re-organize markup structure for simplification (removes excessive
 nested divs).
 - Restructure CSS so that we don't need to duplicate selectors for every
 different control type. Related: #30713, which may not be able to be fixed
 in a reasonable way but this addresses the biggest pain point that it
 causes.
 - Remove CSS for box around preview, which hasn't been visible since
 #31336 (box color is the background color).
 - Don't set a min-height on the media preview, to prevent stretched images
 and awkward spacing. See #36175 for additional considerations such as max-
 height.
 - Remove 2px border radius from images in media controls (including file
 type icons).
 - Note the large amount of net red in the patch.
 - Most of the PHP changes are indentation changes; actual changes are in
 reorganizing the repetitive nested divs.

 For now, let's leave the issue of the hierarchy between the change and
 remove buttons for another ticket. All of the issues listed above
 primarily have the net effect of cleaning up large amount of css (much of
 which is legacy from headers/elsewhere and not needed), which will make it
 much easier to improve the media controls moving forward. There are a
 couple of very minor visual changes as noted above, but most users will
 not notice them. Further design improvements can happen more easily once
 this is in. Note that the header images control was left completely as-is,
 since it eventually needs to be merged back into the new generic media
 controls anyway, see #36581.

 This will likely break patches for tickets like #36175, but I'd prefer to
 get this in and then go back to adjust accordingly. As a result, the
 sooner we can get this in, the better, so that we can loop back to the
 other tickets with patches that are milestoned for 4.6.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30618#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform