[wp-trac] [WordPress Trac] #9993: Rss and atom feeds are dropping some characters
WordPress Trac
noreply at wordpress.org
Fri Apr 29 01:48:13 UTC 2016
#9993: Rss and atom feeds are dropping some characters
--------------------------------------+--------------------------
Reporter: pm24601 | Owner: stevenkword
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.6
Component: Feeds | Version: 2.7.1
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+--------------------------
Comment (by netweb):
Replying to [comment:25 stevenkword]:
> This might be a case where the naming conventions don't quite make
sense. Both Atom and RSS feeds use the same `the_title_rss()` method in
their respective templates. The only difference being that the Atom
template wraps the output in CDATA ,which would be unnecessary, but not
problematic after this change.
>
> Ideally, since both templates use XML (the export component too), naming
the method `the_title_xml()` would have been more appropriate. While we
do have the ability to add unit tests for Atom as of 4.5, I think the
tests proposed in this ticket cover those test cases. As a future part of
adding test coverage for feeds, I would like to add a new `common.php` to
`/tests/feed/` to help make things more obvious.
Because the functionality is different isn't this even more reason to add
unit tests for Atom?
Also looking and `the_title_rss()` is also used in
[https://core.trac.wordpress.org/browser/branches/4.5/src/wp-
admin/includes/export.php#L426 src/wp-admin/includes/export.php#L426],
sadly there are zero export unit tests at the moment, there is a patch
adding export unit tests in #22435 but they are dependant on the new
Export API enhancements in that ticket.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/9993#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list