[wp-trac] [WordPress Trac] #35126: Improvements for the new .button-link CSS class

[WordPress Trac]

#35126: Improvements for the new .button-link CSS class
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  Cheffheid
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.6
Component:  Administration                       |     Version:  4.4
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing 2nd-opinion  |     Focuses:  ui,
                                                 |  accessibility
-------------------------------------------------+-------------------------
Changes (by afercia):

 * focuses:  ui => ui, accessibility
 * milestone:  Future Release => 4.6


Comment:

 Personally, I like the direction here and I think this would make the
 `.button-link` class more useful and easier to use. A few things to
 consider, to improve the patch:
 - usually, links inside list tables are not underlined see `.widefat a` in
 `common.css` I'd suggest to do the same for `.button-link` when inside
 list tables
 - maybe worth searching all the CSS for `text-decoration: none;` to check
 if there are special cases that should be addressed
 - though I'd agree some styles should be consistent across all the
 WordPress ecosystem, I'm pretty sure the maintainers of Press This and the
 Customizer would like to keep the styles unchanged, since they're both
 sort of self-contained applications

 Any thougths more than welcome. /cc @helen @michaelarestad
 @celloexpressions

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35126#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform