[wp-trac] [WordPress Trac] #36666: Enhance `remove_theme_support()` so that it can take additional arguments

[WordPress Trac]

#36666: Enhance `remove_theme_support()` so that it can take additional arguments
------------------------------------+------------------------------
 Reporter:  flixos90                |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Themes                  |     Version:  3.0
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+------------------------------

Comment (by flixos90):

 Replying to [comment:12 jmichaelward]:
 The problem with `get_post_types_by_support()` is that it does not have to
 do with theme support. When you call this function on the
 `after_setup_theme` hook, it will always return an empty array because the
 post types are not registered at this point (since `after_setup_theme`
 executes before `init`). That's why I meant we cannot use this function.
 Sorry, maybe my original post was unclear there.

 > Will do. This is only my third ticket and I don't yet have a lot of
 experience working with Subversion, so it's not always clear to me when to
 patch a single file (since that's all I've been editing), or when to patch
 everything. I've been working from
 [https://make.wordpress.org/core/handbook/tutorials/trac/submitting-a-patch/
 this article]. Should I just be ignoring step one and patching everything
 instead?

 That's perfectly fine, new contributors are always welcome! :) In general,
 you should always provide full diffs, even if you only edit one file (at
 least I've never heard anything contrary). Otherwise the workflow to apply
 patches does not work properly since it won't know which file to patch.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36666#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform