[wp-trac] [WordPress Trac] #36644: Make admin menu skip links accessible to developers

[WordPress Trac]

#36644: Make admin menu skip links accessible to developers
-------------------------------------+-------------------------------------
 Reporter:  littler.chicken          |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  4.6
Component:  Administration           |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-docs     |     Focuses:  accessibility,
  2nd-opinion                        |  administration
-------------------------------------+-------------------------------------

Comment (by littler.chicken):

 Thanks for looking it over, Andrea; I appreciate it.

 > Interesting idea and worth considering. Not sure adding the ID on the
 heading in `do_settings_sections` would help with "tabs" in plugin
 settings pages since these tabs are usually printed out by other means.
 My thought with adding the ID is that because it's something developers
 are already implementing (if they're using the Settings API), it's an easy
 add. Not everyone will want to modify the skip links, but this is an easy
 anchor if they do. My example with the tabbed settings page is that the
 main anchor lands users above the tabs. With a tabbed settings page, the
 filter gives developers a way to allow users to either land above the
 tabs, or to bypass them and go directly to the settings form instead of
 having to go through each tab. At the moment, though, there aren't anchors
 available in the form, so a developer would have to add a hidden anchor
 after their tabs, to get a target for the skip link. With a section header
 starting the top of the form, that seems like an easy place to land that.

 > By the way, the main issue I see here is that many browsers still don't
 give focus to elements targeted with an anchor link if these elements are
 not focusable. That's the reason why the main content `div` has a
 `tabindex="0"` attribute.
 > On the other hand, I'm not sure making some elements focusable, for
 example a heading, would be a good thing. I'd recommend to discuss a bit
 this in the next accessibility team meeting.

 Thanks, discussion sounds fine.

 > Couple things about the patch so far:
 > - the admin toolbar ID is `wp-toolbar` not `wpbody-toolbar`
 > - the settings section h2 heading text shouldn't use `esc_attr()`
 Thanks for catching both of those! Sorry about that.

 I had also raised the question of whether the skip links should be set up
 as a `<ul>`, but I think that might be difficult to make consistent with
 the front end, in situations where the WP toolbar skip link is combining
 with whatever the theme outputs--they are just `<a>`, no list setup there.
 So I would expect we don't want to try that in the admin.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36644#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform