[wp-trac] [WordPress Trac] #35457: Theme installer upload button improvements

[WordPress Trac]

#35457: Theme installer upload button improvements
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:  afercia
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.6
Component:  Themes                   |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-           |     Focuses:  ui, accessibility,
  screenshots                        |  javascript
-------------------------------------+-------------------------------------

Comment (by afercia):

 Refreshed patch:
 - makes the upload button a button
 - adds an `aria-expanded` attribute on the button: as a consequence the
 button text must always be "Upload Theme" since this button behaves like a
 toggle
 - no more complicated CSS selectors, uses a new CSS class `.hide-if-
 upload-view` to hide elements
 - restores the `themes.router.navigate()` "upload" route mistakenly
 removed in [37221]
 - adds a notice displayed only when JavaScript is off, as the Media
 Library grid screen already does
 - adds some `hide-if-no-js` to various elements

 The part related to the Add Plugin screen should be handled in #35429,
 going to reopen it.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35457#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform