[wp-trac] [WordPress Trac] #36306: Smiley in shortcode attribute breaks the parsing

[WordPress Trac]

#36306: Smiley in shortcode attribute breaks the parsing
--------------------------+-----------------------
 Reporter:  Unyson        |       Owner:  pento
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  4.6
Component:  Emoji         |     Version:
 Severity:  normal        |  Resolution:  fixed
 Keywords:                |     Focuses:  template
--------------------------+-----------------------
Changes (by pento):

 * owner:   => pento
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"37298"]:
 {{{
 #!CommitTicketReference repository="" revision="37298"
 Smilies: Move `convert_smilies` to happen later in the `the_content`
 filter.

 In particular, we want it to occur after shortcode handling. The smiley
 conversion routine doesn't have any concept of shortcode structure, so may
 inadvertantly replace a smiley with HTML inside a shortcode attribute,
 which will cause the shortcode to not be parsed correctly.

 Props Unyson for the initial suggested fix.

 Fixes #36306.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36306#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform