[wp-trac] [WordPress Trac] #36590: POST['nav-menu-data'] breaks other POST values

[WordPress Trac]

#36590: POST['nav-menu-data'] breaks other POST values
-------------------------------------+-------------------------------------
 Reporter:  Unyson                   |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  4.5.2
Component:  Menus                    |     Version:  4.5
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-unit-      |     Focuses:  javascript,
  tests                              |  administration
-------------------------------------+-------------------------------------

Comment (by dd32):

 Replying to [comment:16 ericlewis]:
 > What are our considerations in not introducing functions in a minor
 release? If it provides unit testing for a problematic piece of code then
 that seems beneficial.

 If the function exists in the same file, not a problem at all.
 If the function exists in a different file, we avoid it.
 The main reason is that failed updates can leave a site only partially
 updated and brings the potential for a fatal error due to the cross-
 dependency.

 In this case, the fatal would only be present on the nav menu's screen so
 a fatal isn't fatal to the site, the user can still continue with another
 update, however it could also be added to trunk in the different file, and
 included inline in 4.5 without significant issue (We'd just not be able to
 include the unit test in the 4.5 branch).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36590#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform