[wp-trac] [WordPress Trac] #36578: wp_ajax_send_attachment_to_editor() bug

[WordPress Trac]

#36578: wp_ajax_send_attachment_to_editor() bug
------------------------------+------------------------
 Reporter:  otterstein        |       Owner:  joemcgill
     Type:  defect (bug)      |      Status:  assigned
 Priority:  normal            |   Milestone:  4.5.1
Component:  Media             |     Version:  4.5
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+------------------------

Comment (by boonebgorges):

 The failures referenced by @swissspidy are pretty baffling to sort out.
 Briefly, the generation of user fixtures during ajax tests is happening in
 such a way that the `WP_UnitTest_Generator_Sequence` incrementor - which
 is intended to ensure uniqueness for user_login etc - is being incremented
 inconsistently or in an inconsistent order. I think that this has
 something to do with the fact that some AJAX tests are run in separate
 processes, along with some weirdness having to do with the way that
 PHPUnit loads `setUpBeforeClass()` early in the process of running tests.

 In any case, a tweak to the way that the fixture incrementor works appears
 to resolve the problem. It also solves a developer-facing annoyance,
 discussed in #35199, which is that a generated user might have user_login
 "user_5" but user_email "user_6 at example.com".
 https://core.trac.wordpress.org/attachment/ticket/35199/35199.diff should
 fix all of this.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36578#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform