[wp-trac] [WordPress Trac] #34359: Cache output of `wp_upload_dir()` to improve performance

[WordPress Trac]

#34359: Cache output of `wp_upload_dir()` to improve performance
-------------------------------------------+-------------------------------
 Reporter:  mikeschroder                   |       Owner:  azaozz
     Type:  defect (bug)                   |      Status:  reopened
 Priority:  normal                         |   Milestone:  4.5
Component:  Media                          |     Version:
 Severity:  major                          |  Resolution:
 Keywords:  needs-testing has-patch early  |     Focuses:  multisite,
                                           |  performance
-------------------------------------------+-------------------------------
Changes (by barry):

 * status:  closed => reopened
 * resolution:  fixed =>
 * severity:  normal => major


Comment:

 This broke things on WordPress.com and elsewhere. I don't think it's safe
 to cache the results of {{{ wp_mkdir_p() }}} in a persistent cache, but
 caching it non-persistently seems fine.   I think we need to go back to
 the approach in
 https://core.trac.wordpress.org/attachment/ticket/34359/34359.3.patch,
 storing the results in a non-persistent cache.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34359#comment:60>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform